Merge lp://qastaging/~samothjtm/openlp/bug-1695587 into lp://qastaging/openlp
Proposed by
Johannes Thomas Meyer
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~samothjtm/openlp/bug-1695587 | ||||
Merge into: | lp://qastaging/openlp | ||||
Diff against target: |
73 lines (+42/-4) 2 files modified
openlp/plugins/songs/lib/mediaitem.py (+8/-3) tests/functional/openlp_plugins/songs/test_mediaitem.py (+34/-1) |
||||
To merge this branch: | bzr merge lp://qastaging/~samothjtm/openlp/bug-1695587 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raoul Snyman | Needs Fixing | ||
Tomas Groth | Needs Fixing | ||
Samuel Mehrbrodt | Pending | ||
Review via email: mp+325035@code.qastaging.launchpad.net |
This proposal has been superseded by a proposal from 2017-06-05.
Commit message
added SongBook name, Song Number and Alternative Title to Entire Search
Description of the change
added SongBook name, Song Number and Alternative Title to Entire Search
Unfortunately the tests are failing atm but that has been before my commit as well...
lp:~samothjtm/openlp/bug-1695587 (revision 2746)
[←[1;32mSUCCESS
[←[1;31mFAILURE
Stopping after failure
To post a comment you must log in.
Hi Johannes,
Thank you for contributing to OpenLP! /wiki.openlp. org/Development :Unit_Tests
To get your code merged you must create a test that proves it actually works. Have a look at the wiki for inspiration: https:/