Compiz

Merge lp://qastaging/~samuel-thibault/compiz/ezoom-minmax into lp://qastaging/compiz/0.9.13

  1. ezoom-minmax
  2. Merge into 0.9.13
Proposed by Samuel thibault
Status: Needs review
Proposed branch: lp://qastaging/~samuel-thibault/compiz/ezoom-minmax
Merge into: lp://qastaging/compiz/0.9.13
Diff against target: 359 lines (+80/-80)
2 files modified
plugins/ezoom/ezoom.xml.in (+61/-61)
plugins/ezoom/src/ezoom.cpp (+19/-19)
To merge this branch: bzr merge lp://qastaging/~samuel-thibault/compiz/ezoom-minmax
Reviewer Review Type Date Requested Status
Alberts Muktupāvels Needs Information
Compiz Maintainers Pending
Review via email: mp+343183@code.qastaging.launchpad.net

Commit message

Inverse minimum_zoom and autoscale_min into maximum_zoom and autoscale_max

The options themselves were saying: "A value of 0.5 equals 2x zoom", i.e. the value is counterintuitive, and it is much more user-friendly to inverse the values presented to the user.

To post a comment you must log in.
lp://qastaging/~samuel-thibault/compiz/ezoom-minmax updated
4145. By Samuel thibault

Inverse meaning of specific zoom level values

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Will not this break existing settings?

review: Needs Information
Reply
Revision history for this message
Samuel thibault (samuel-thibault) wrote :

Well, yes. I don't know how compiz usually copes with such kind of configuration change?

Reply
Revision history for this message
Alberts Muktupāvels (muktupavels) :
Reply
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Unfortunately I don't know either... Probably xml is used to limit min/max values in GUI, but that is only my guess.

There probably should be some migration script or maybe code could detect that value is in old range and automatically update to new? No idea about renamed setting...

Reply
Revision history for this message
Samuel thibault (samuel-thibault) wrote :

Here detection would be easy indeed: factors used to be always <= 1, and after this change they'd be always >= 1

Reply
Revision history for this message
Alex ARNAUD (alexarnaud) wrote :

It's what Andyrock points out to me: https://bazaar.launchpad.net/~unity-team/unity/trunk/files/head:/tools/migration-scripts/

Best regards,
Alex.

Reply
Revision history for this message
Samuel thibault (samuel-thibault) :
Reply
Revision history for this message
Alex ARNAUD (alexarnaud) wrote :

@Alberts Muktupāvels: We won't work on migration script. So except if you want to work on it or merge it like it is you could close this as WONTFIX.

In the past gsettings have changed and broke configuration without any migration script:
My bug report about that: https://bugs.launchpad.net/compiz/+bug/1712570
The change that has created migration issue: https://bugs.launchpad.net/compiz/+bug/1201061

Best regards,
Alex.

Reply
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

I am not the one who decides that... I don't even use compiz!

Reply

Unmerged revisions

4145. By Samuel thibault

Inverse meaning of specific zoom level values

4144. By ksamak

Inverse minimum_zoom and autoscale_min into maximum_zoom and autoscale_max

The options themselves were saying: "A value of 0.5 equals 2x zoom", i.e. the
value is counterintuitive, and it is much more user-friendly to inverse the
values presented to the user.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches