Merge lp://qastaging/~samuel-thibault/compiz/shortcuts into lp://qastaging/compiz/0.9.13

Thanks for your work, it's really appreciated and something I really had in mind since long time...

However, a part few cleanups (and a bit more of C++11 features usage), we've to think as this will deal with Unity, since there we're using XI2 already for some input monitor operations (mostly for edge events and for monitoring the mouse position when menus are opened, plus few other things), and the fact is that we disable such events when we don't need them.

Now, in theory we could move all that to compiz, introducing new actions types, but the problem now is that we can't really deal with all this work now that we're focused in GNOME

Another possibility is just to make unity to save the state on load with XIGetSelectedEvents and resume that state when we disable it, but in general I'd prefer the events not to be selected unless there's anything else that need them.

Another possibility is just make unity to keep them always enabled, and never toggle them.

In any case, it would be cool if you could test it with your changes, and in case propose a fix for it too. As without that change we can't land compiz in ubuntu (and thus upstream) easily as it could be prone to regressions.

Hello,

I agree that selecting XI2 events only when needed would be ideally ideal, but
the obtained optimization (avoiding to trivially convert from XI2 events to core
events) does not seem to me worth the complexity cost.

Assuming that we avoid that complexity and just make compiz use XI2 whenever
available (Unity requires it anyway), things would be much simpler:

- Unity can use XIGetSelectedEvents() to determine what Compiz configured, and
merge it before XISelectEvents() and resume it, as you suggested.

- Compiz only disables XI2 temporarily within PrivateWindow::reparent(), so it
can also use XIGetSelectedEvents() to restore it as it was, either the original
compiz set or the set as merged by Unity.

That way, both sides are easily careful about what was set by the other side.

What do you think?

Samuel

Ok, that would look reasonable.

Could you possibly do that unity side of work too?
As otherwise this MP might stuck until I've time for that (and it might take a while).

Cheers

Sure, I'll do the unity side :)
(probably on Tuesday)

Sorry I got preempted by other issues. I have pushed the compiz side, and will work on the unity side.

Hello,

I have pushed the unity side on https://code.launchpad.net/~samuel-thibault/unity/shortcuts

Samuel