Merge lp://qastaging/~samuel-thibault/compiz/xysync2 into lp://qastaging/compiz/0.9.13
Proposed by
Samuel thibault
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~samuel-thibault/compiz/xysync2 |
| Merge into: | lp://qastaging/compiz/0.9.13 |
| Diff against target: |
35 lines (+8/-14) 1 file modified
plugins/ezoom/src/ezoom.cpp (+8/-14) |
| To merge this branch: | bzr merge lp://qastaging/~samuel-thibault/compiz/xysync2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Compiz Maintainers | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Alberts Muktupāvels (muktupavels) wrote | # |
Revision history for this message
| Samuel thibault (samuel-thibault) wrote | # |
Revision history for this message
| Samuel thibault (samuel-thibault) wrote | # |
Unmerged revisions
- 4146. By Samuel thibault
-
No need to use the double version of sqrt
- 4145. By Samuel thibault
-
Normalize combination of xdiff and ydiff
- 4144. By Samuel thibault
-
Synchronize X and Y translation capping
Capping X and Y separately brings some discontinuity visual effect: instead of
terminating the translation at the same time, the axis getting capped (e.g. X)
will terminate the translation later, so that at the point when the other axis
(here, Y) is finished translating, there is a discontinuity in the movement: we
suddenly have only X translation, and no Y translation any more. This does not
look very smooth.This changes it by simply capping both axis at the same time.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Code/change looks good to me, but no idea about math part... Does that really produce expected result?
For example xdiff = 2.5 and ydiff = 3.5. With current code xamount = 2.5 and yamount = 3.5, but with your change amount is now 4.301162634. Is that expected?