Compiz

Merge lp://qastaging/~sao/compiz/spread_windows_workspace into lp://qastaging/~compiz/compiz/ubuntu

  1. spread_windows_workspace
  2. Merge into ubuntu
Proposed by Oliver Sauder
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp://qastaging/~sao/compiz/spread_windows_workspace
Merge into: lp://qastaging/~compiz/compiz/ubuntu
Diff against target: 52 lines (+32/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/087_new_scale_defaults.patch (+23/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~sao/compiz/spread_windows_workspace
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Disapprove
Review via email: mp+66201@code.qastaging.launchpad.net

Description of the change

This fixes the issue that the window spread will only show applications on the current workspace.
It does this basically by changing the default key Super+S to the option initiate_output_key.

See branch lp:~sao/unity/spread_windows_workspace which fixes the issue that app spread only shows applications on the current workspace.

Not sure if this should be merged before Bug 690143 is fixed as well.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Olivier,

Thanks for your patch:

However, I'm afraid that the bug report isn't actually about changing that. I think that "When performing a window spread" refers to initiatize the spread only from the launcher icon, not any shortcut.

The shortcut decision has been made by the design team. You can have a look at debian/changelog where I document every changes (you can check easily! ;)). See bug #723273 for the actual discussion.

In a nutshell, to fix this bug, there is some code involved in unity, from the launcher click, and not for the shortcut itself which behave as intended by design. I think that's what you have done in your other merge request, so that's nice ;)

I'll then put the merge as rejected. Do not hesitate to propose any other merge for compiz/unity of course :)

review: Disapprove
Revision history for this message
Oliver Sauder (sao) wrote :

Well, I thought this change was a bit strange to have two different changes in one bug.
Was good practice anyway ;).

Thanks for the changelog hint. Alt+Shift+Up is actually used for this. Good to know ;).

Unmerged revisions

620. By Oliver Sauder

* debian/patches/087_new_scale_defaults.patch:
  - Default key Super+W now set to only spread windows of
    current workspace (LP: #689733)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: