Unity

Merge lp://qastaging/~sao/unity/doubleclick_on_panel_to_unmaximize into lp://qastaging/unity

  1. doubleclick_on_panel_to_unmaximize
  2. Merge into trunk
Proposed by Oliver Sauder
Status: Merged
Merged at revision: 918
Proposed branch: lp://qastaging/~sao/unity/doubleclick_on_panel_to_unmaximize
Merge into: lp://qastaging/unity
Diff against target: 34 lines (+3/-3)
2 files modified
src/PanelTitlebarGrabAreaView.cpp (+2/-2)
src/PanelTitlebarGrabAreaView.h (+1/-1)
To merge this branch: bzr merge lp://qastaging/~sao/unity/doubleclick_on_panel_to_unmaximize
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+52150@code.qastaging.launchpad.net

Description of the change

The mouse events from the Nux InputArea seem to be a bit "bumpy" (also mentioned in some FIXME in the unity code).

The OnMouseClick is only emitted when _event_processor.MouseIn() is true, which does not apply when clicking on the left side of the title bar.

Therefore, as a workaround I've replaced the OnMouseClick event with OnMouseUp to implement the double click behavior. In the long run I suppose it would be desirable to fix the mouse events in Nux.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

right about the FIXME, I had to do that manually in the code as you have been able to know. :)

Nice track about the _event_processor.MouseIn()! So let's go with OnMouseUp now! Approved! Thanks a bunch :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.