Merge lp://qastaging/~sao/unity/show_command_history into lp://qastaging/unity
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Neil J. Patel | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merge reported by: | Neil J. Patel | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://qastaging/~sao/unity/show_command_history | ||||
| Merge into: | lp://qastaging/unity | ||||
| Diff against target: |
60 lines (+18/-4) 3 files modified
plugins/unityshell/src/PlaceEntryRemote.cpp (+15/-0) plugins/unityshell/src/PlacesView.cpp (+0/-4) tests/CMakeLists.txt (+3/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~sao/unity/show_command_history | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Neil J. Patel (community) | Approve | ||
| Alex Launi (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This fixes the issue that the command history is not shown first time after login.
Branch lp:~sao/unity-place-applications/load-history-when-activating fixes the issue that the history gets added when the command history is activated.
This branch however fixes the issue, that such an active signal is not send to the place as such is sent before the place is successfully connected.
If this is a case this branch introduces the ability that the activation process is redone after a place is successfully connected, updated and active.
One issue remains however: Currently as I see it the section cannot be added asynchronously. So for a place which uses sections just after login when that place is opened those won't be shown.
Not sure if this is relevant for now. A new bug report might be reported for this.
| Oliver Sauder (sao) wrote | # |
I merged this in, and restarted but my alt-f2 still doesn't show history.