qtubuntu

Merge lp://qastaging/~saviq/qtubuntu/more-robust-desktop-parsing into lp://qastaging/qtubuntu

  1. more-robust-desktop-parsing
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Rejected
Rejected by: Gerry Boland
Proposed branch: lp://qastaging/~saviq/qtubuntu/more-robust-desktop-parsing
Merge into: lp://qastaging/qtubuntu
Prerequisite: lp://qastaging/~saviq/qtubuntu/respect-path
Diff against target: 89 lines (+43/-12)
1 file modified
src/modules/application/application_manager.cc (+43/-12)
To merge this branch: bzr merge lp://qastaging/~saviq/qtubuntu/more-robust-desktop-parsing
Reviewer Review Type Date Requested Status
Gerry Boland (community) Disapprove
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+176931@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-07-25.

Commit message

Make desktop file parsing more robust.

Ignore spaces around "=" and error out on malformed lines.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:158
http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/45/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-saucy-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-saucy-armhf-ci/33/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/qtubuntu-ci/45/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/qtubuntu-autolanding/41/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-autolanding/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

SurfaceFlinger support dropped, so this MR invalid

review: Disapprove

Unmerged revisions

158. By Michał Sawicz

Also skip if just the key was provided.

157. By Michał Sawicz

Ignore spaces around "=" in .desktop files.

156. By Michał Sawicz

Scan for a [Desktop Entry] group, don't assume it's on the first line.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches