simplestreams

Merge lp://qastaging/~saviq/simplestreams/add-vhd-images into lp://qastaging/simplestreams

  1. add-vhd-images
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp://qastaging/~saviq/simplestreams/add-vhd-images
Merge into: lp://qastaging/simplestreams
Diff against target: 46 lines (+18/-1)
2 files modified
tools/make-test-data (+2/-0)
tools/toolutil.py (+16/-1)
To merge this branch: bzr merge lp://qastaging/~saviq/simplestreams/add-vhd-images
Reviewer Review Type Date Requested Status
Scott Moser (community) Needs Information
Server Team CI bot continuous-integration Approve
Robert C Jennings Pending
Review via email: mp+323325@code.qastaging.launchpad.net

Commit message

Include VHD images in the stream

Description of the change

Note this suffers from bug #1686750

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

The patch here looks fine, but I wont merge it without someone on cpc team approval.

I do have the general dislike of Ubuntu publishing .vmdk and .qcow2 and
 .here-is-another-format-that-a-hypervisor-could-convert-from-the-open-standard-qcow2.

But that is my only objection, and based on the many formats we publish, we've decided not to use Ubuntu's leverage to help the industry with interoperability.

lp://qastaging/~saviq/simplestreams/add-vhd-images updated
450. By Michał Sawicz

Include VHD images in the stream

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:450
https://jenkins.ubuntu.com/server/job/simplestreams-ci/33/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-amd64/33
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-arm64/33
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-ppc64el/33
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=metal-s390x/33
    SUCCESS: https://jenkins.ubuntu.com/server/job/simplestreams-ci/nodes=vm-i386/33

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/simplestreams-ci/33/rebuild

review: Approve (continuous-integration)
Revision history for this message
Scott Moser (smoser) wrote :

Is this still necessary?
Desireable?

review: Needs Information
Revision history for this message
Michał Sawicz (saviq) wrote :

I've decided to convert from qcow2 because of the large size (30G) of VHD images, so I'm fine dropping this.

Revision history for this message
Scott Moser (smoser) wrote :

Hi.
We've moved simplestreams from bzr on launchpad to git on launchpad.
I'm going to mark this merge proposal as Rejected based only on
the fact that it is a bzr based merge proposal.

Please feel free to re-submit the merge proposal using the launchpad git.
Hopefully the cloud-init doc at
 http://cloudinit.readthedocs.io/en/latest/topics/hacking.html
should give you an idea on how to do that.

Unmerged revisions

450. By Michał Sawicz

Include VHD images in the stream

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches