Merge lp://qastaging/~saviq/ubuntu-themes/add-cellular-icons into lp://qastaging/ubuntu-themes

Proposed by Michał Sawicz
Status: Needs review
Proposed branch: lp://qastaging/~saviq/ubuntu-themes/add-cellular-icons
Merge into: lp://qastaging/ubuntu-themes
Diff against target: 1862 lines (+1746/-2)
21 files modified
Makefile (+18/-2)
suru-icons/status/scalable/no-service.svg (+97/-0)
suru-icons/status/scalable/no-service_sim-1.svg (+103/-0)
suru-icons/status/scalable/no-service_sim-2.svg (+103/-0)
suru-icons/status/scalable/service-disabled.svg (+97/-0)
suru-icons/status/scalable/service-disabled_sim-1.svg (+103/-0)
suru-icons/status/scalable/service-disabled_sim-2.svg (+108/-0)
suru-icons/status/scalable/signal-00.svg (+80/-0)
suru-icons/status/scalable/signal-100.svg (+96/-0)
suru-icons/status/scalable/signal-25.svg (+80/-0)
suru-icons/status/scalable/signal-50.svg (+80/-0)
suru-icons/status/scalable/signal-75.svg (+80/-0)
suru-icons/status/sources/2g.svg (+90/-0)
suru-icons/status/sources/3g.svg (+92/-0)
suru-icons/status/sources/4g.svg (+86/-0)
suru-icons/status/sources/edge.svg (+85/-0)
suru-icons/status/sources/hspa-plus.svg (+69/-0)
suru-icons/status/sources/hspa.svg (+69/-0)
suru-icons/status/sources/roaming.svg (+84/-0)
suru-icons/status/sources/sim-1.svg (+63/-0)
suru-icons/status/sources/sim-2.svg (+63/-0)
To merge this branch: bzr merge lp://qastaging/~saviq/ubuntu-themes/add-cellular-icons
Reviewer Review Type Date Requested Status
Matthieu James (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Ubuntu Artwork Packagers Pending
Review via email: mp+257713@code.qastaging.launchpad.net

Commit message

Add new cellular icons

Description of the change

Add new cellular icons as well as generate all the 105 level×network×sim combinations.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
436. By Michał Sawicz

Refactor Makefile to be cleaner; move sources to sources dir

437. By Michał Sawicz

No need for _SIM

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Matthieu James (tiheum) wrote :

All the various possible states are here. Everything looks fine as long as the different sizes between the indicators with and without the data connectivity is not an issue.

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote :

> All the various possible states are here. Everything looks fine as long as the different sizes between the indicators with and without the data connectivity is not an issue.

Yup, that's fine, we maintain aspect ratio now. It'd be interesting to
know whether those icons are actually meant to be used (vs. colors as
described in https://wiki.ubuntu.com/Networking#sim-names).

Unmerged revisions

437. By Michał Sawicz

No need for _SIM

436. By Michał Sawicz

Refactor Makefile to be cleaner; move sources to sources dir

435. By Michał Sawicz

Add cellular icons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches