unity-2d

Merge lp://qastaging/~saviq/unity-2d/desktop-title into lp://qastaging/unity-2d

desktop-title
Merge into trunk

Proposed by Michał Sawicz on 2011-09-30

Status:

Merged

Approved by:

Alberto Mardegan on 2011-09-30

Approved revision:

749

Merged at revision:

749

Proposed branch:

lp://qastaging/~saviq/unity-2d/desktop-title

Merge into:

lp://qastaging/unity-2d

Diff against target:

37 lines (+7/-3)

1 file modified

panel/applets/appname/appnameapplet.cpp (+7/-3)

To merge this branch:

bzr merge lp://qastaging/~saviq/unity-2d/desktop-title

Related bugs:

Bug #732016: UIFe: Desktop should be titled	Low	Fix Committed
Bug #869586: The title "Desktop" needs to displayed in panel	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alberto Mardegan (community)		2011-09-30	Approve on 2011-09-30
Łukasz Zemczak	functional		Approve on 2011-09-30
Review via email: mp+77694@code.qastaging.launchpad.net

Commit message

[panel] display "Desktop" label when no application is active

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2011-09-30:

Works fine for me!

review: Approve (functional)

Revision history for this message

Alberto Mardegan (mardy) wrote on 2011-09-30:

Works fine for me too, and the code looks great.
I've only one concern: when you open the Dash, the title bar still shows "Desktop". But I suppose I will fix that with bug 860400, so I think that the current behaviour is acceptable.

review: Approve

Revision history for this message

Florian Boucault (fboucault) wrote on 2011-10-03:

The code does not seem specific enough to the desktop being focused.
@Alberto: I don't see why this issue is acceptable and how bug #860400 relates.

Revision history for this message

Michał Sawicz (saviq) wrote on 2011-10-03:

@fboucault - bug 860400 relates in the sense that this part of code will be reworked anyway to provide dash window buttons.