Unity 8

Merge lp://qastaging/~saviq/unity8/fix-frequent-app-ids into lp://qastaging/unity8

  1. fix-frequent-app-ids
  2. Merge into trunk
Proposed by Michał Sawicz
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 414
Merged at revision: 425
Proposed branch: lp://qastaging/~saviq/unity8/fix-frequent-app-ids
Merge into: lp://qastaging/unity8
Diff against target: 121 lines (+4/-85)
2 files modified
Dash/Apps/AppsAvailableForDownloadModel.qml (+0/-81)
Dash/Apps/FrequentlyUsedAppsModel.qml (+4/-4)
To merge this branch: bzr merge lp://qastaging/~saviq/unity8/fix-frequent-app-ids
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
David Barth (community) Needs Fixing
Gerry Boland Pending
Review via email: mp+190161@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-10-01.

Commit message

Fix frequent application IDs and drop old AppsAvailableForDownload model.

Description of the change

This needs url-dispatcher trunk.

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote : Posted in a previous version of this proposal

For reference, the correct appid string for Facebook is:

"appid://com.ubuntu.developer.webapps.webapp-facebook/webapp-facebook/current-user-version"

as confirmed by Ted on IRC.

review: Needs Fixing
Revision history for this message
David Barth (dbarth) wrote :

The gmail appid should be:

appid://com.ubuntu.developer.webapps.webapp-gmail/webapp-gmail/current-user-version

ie, replace facebook in the package name with gmail

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:413
http://jenkins.qa.ubuntu.com/job/unity8-ci/1331/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4833
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2692
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2197
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/354
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1331
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1331/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1330
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1011
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/708
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/708/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2694
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2694/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2231
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2243

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1331/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

com.ubuntu.developer.webapps.webapp-facebook/webapp-gmail sounds wrong

review: Needs Fixing
lp://qastaging/~saviq/unity8/fix-frequent-app-ids updated
414. By Michał Sawicz

s/facebook/gmail/

Revision history for this message
Albert Astals Cid (aacid) wrote :

Works

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:414
http://jenkins.qa.ubuntu.com/job/unity8-ci/1346/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4885
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2756
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2212
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/369
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1346
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1346/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1345
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1063
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/760
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/760/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2758
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2758/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2294
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2309

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1346/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches