Merge lp://qastaging/~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records into lp://qastaging/knowledge-addons/7.0
Proposed by
El Hadji Dem (http://www.savoirfairelinux.com)
| Status: | Rejected |
|---|---|
| Rejected by: | Yannick Vaucher @ Camptocamp |
| Proposed branch: | lp://qastaging/~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records |
| Merge into: | lp://qastaging/knowledge-addons/7.0 |
| Diff against target: |
1626 lines (+1544/-0) 14 files modified
document_multiple_records/__init__.py (+26/-0) document_multiple_records/__openerp__.py (+55/-0) document_multiple_records/document.py (+66/-0) document_multiple_records/document_view.xml (+30/-0) document_multiple_records/i18n/document_multiple_records.pot (+140/-0) document_multiple_records/static/src/js/document.js (+39/-0) document_multiple_records/static/src/xml/document.xml (+10/-0) document_multiple_records/wizard/__init__.py (+25/-0) document_multiple_records/wizard/document_wizard.py (+56/-0) document_multiple_records/wizard/document_wizard_view.xml (+41/-0) wiki_wikimedia/__init__.py (+21/-0) wiki_wikimedia/__openerp__.py (+37/-0) wiki_wikimedia/static/src/js/wiki_wikimedia.js (+9/-0) wiki_wikimedia/static/src/lib/instaview.js (+989/-0) |
| To merge this branch: | bzr merge lp://qastaging/~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records |
| Related bugs: | |
| Related blueprints: |
Attach same document to multiple records
(Undefined)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sandy Carter (http://www.savoirfairelinux.com) | Needs Resubmitting | ||
| OpenERP knowledge addons | Pending | ||
| Holger Brunn (Therp) | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-02-06.
Description of the change
Added document_
To post a comment you must log in.
Revision history for this message
| El Hadji Dem (http://www.savoirfairelinux.com) (eh-dem) wrote | # |
Revision history for this message
| Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote | # |
review:
Needs Resubmitting
Revision history for this message
| Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote | # |
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
Unmerged revisions
- 3. By El Hadji Dem (http://www.savoirfairelinux.com)
-
[IMP] change the date and owner.
- 2. By El Hadji Dem (http://www.savoirfairelinux.com)
-
[ADD] added document_
multiple_ records module: it allows to add the same document for multiple records - 1. By Holger Brunn (Therp)
-
[ADD] a wikimedia syntax parser, courtesy of
http://en.wikipedia. org/wiki/ User:Pilaf/ InstaView
This is already pretty usable, OpenERP specifics will have to be added as
needed.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think you should follow the rule to put models into the subdir model, with one file per model.
#29 why no local import here?
#135ff could you explain those lines? To me it seems we leave stuff in the database there that we don't want
#363 comment
#377 this text seems quite misleading. How about 'Add existing document/
$470 ir.attachment.
Further I don't see where you do any refcount. How do you take care that if attachment A is linked to records R1, R2 and R3, A stays if I delete R1 and R2, but will be deleted when I delete R3?
And how do you deal with attachments being only visible to people who have read permissions on the document given in res_model/res_id? I think you'll have to override that to also take the other linked records into account.
For usability, I'd also add a function field that combines res_model and res_id to a reference field.