Merge lp://qastaging/~savoirfairelinux-openerp/openerp-canada/fix_l10n_ca_check_print_top into lp://qastaging/openerp-canada

Status: Merged
Approved by: Sandy Carter (http://www.savoirfairelinux.com)
Approved revision: 30
Merged at revision: 30
Proposed branch: lp://qastaging/~savoirfairelinux-openerp/openerp-canada/fix_l10n_ca_check_print_top
Merge into: lp://qastaging/openerp-canada
Diff against target: 930 lines (+474/-313)
7 files modified
l10n_ca_account_check_writing/__init__.py (+0/-1)
l10n_ca_account_check_writing/__openerp__.py (+21/-6)
l10n_ca_account_check_writing/account_voucher.py (+2/-2)
l10n_ca_account_check_writing/report/README.txt (+9/-0)
l10n_ca_account_check_writing/report/__init__.py (+0/-3)
l10n_ca_account_check_writing/report/l10n_ca_check_print.py (+32/-27)
l10n_ca_account_check_writing/report/l10n_ca_check_print_top.rml (+410/-274)
To merge this branch: bzr merge lp://qastaging/~savoirfairelinux-openerp/openerp-canada/fix_l10n_ca_check_print_top
Reviewer Review Type Date Requested Status
Maxime Chambreuil (http://www.savoirfairelinux.com) Approve
Joao Alfredo Gama Batista code review, no tests Approve
Sandy Carter (http://www.savoirfairelinux.com) code review Approve
Review via email: mp+219059@code.qastaging.launchpad.net
To post a comment you must log in.
30. By Maxime Chambreuil (http://www.savoirfairelinux.com)

[FIX] PEP8 issues and add external dependencies on num2words. Update the description accordingly.

Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

LGTM

review: Approve (code review)
Revision history for this message
Joao Alfredo Gama Batista (joao-gama) wrote :

LGTM

review: Approve (code review, no tests)
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve
31. By Marc Cassuto (SFL)

[FIX] fix position of the 3rd table

32. By Marc Cassuto (SFL)

[FIX] fix position of the 2nd table & force date format to be YYYY-MM-DD

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches