Merge lp://qastaging/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType into lp://qastaging/openerp-hr
Proposed by
Sandy Carter (http://www.savoirfairelinux.com)
Status: | Merged |
---|---|
Merged at revision: | 79 |
Proposed branch: | lp://qastaging/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType |
Merge into: | lp://qastaging/openerp-hr |
Diff against target: |
114 lines (+93/-0) 3 files modified
hr_department_sequence/hr_department.py (+2/-0) hr_department_sequence/tests/__init__.py (+29/-0) hr_department_sequence/tests/test_hr_department.py (+62/-0) |
To merge this branch: | bzr merge lp://qastaging/~savoirfairelinux-openerp/openerp-hr/department_sequence_concatination_NoneType |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Katja Matthes (community) | code review | Approve | |
Guewen Baconnier @ Camptocamp | Approve | ||
Daniel Reis | Approve | ||
Pedro Manuel Baeza | code review | Approve | |
Review via email:
|
Description of the change
Fix a name_search bug and add a test to prevent future regressions:
openerp.
TypeError: can only concatenate list (not "NoneType") to list
To post a comment you must log in.
LGTM. You can also make one liner with:
..., name)] + args or [],
Regards.