Merge lp://qastaging/~savoirfairelinux-openerp/openerp-hr/hr_employee_phone_extension into lp://qastaging/openerp-hr
Proposed by
Sandy Carter (http://www.savoirfairelinux.com)
| Status: | Merged |
|---|---|
| Merged at revision: | 76 |
| Proposed branch: | lp://qastaging/~savoirfairelinux-openerp/openerp-hr/hr_employee_phone_extension |
| Merge into: | lp://qastaging/openerp-hr |
| Diff against target: |
252 lines (+221/-0) 6 files modified
hr_employee_phone_extension/__init__.py (+25/-0) hr_employee_phone_extension/__openerp__.py (+55/-0) hr_employee_phone_extension/hr.py (+36/-0) hr_employee_phone_extension/hr_view.xml (+20/-0) hr_employee_phone_extension/i18n/fr.po (+44/-0) hr_employee_phone_extension/i18n/hr_employee_phone_extension.pot (+41/-0) |
| To merge this branch: | bzr merge lp://qastaging/~savoirfairelinux-openerp/openerp-hr/hr_employee_phone_extension |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Reis | lgtm, no test | Approve | |
| Omar (Pexego) | code review | Approve | |
| Maxime Chambreuil (http://www.savoirfairelinux.com) | code review | Approve | |
|
Review via email:
|
|||
Description of the change
This module adds fields for internal and external phone extensions for hr_employees
To post a comment you must log in.
Revision history for this message
| Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) | # |
review:
Approve
(code review)
Revision history for this message
| Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote | # |
Revision history for this message
| Daniel Reis (dreis-pt) | # |
review:
Approve
(lgtm, no test)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Why is the phone expiration date near the Passport Id.
As far as I can see this will be seen in another separator, "Personal Info", under a "Citizenship & Other Info" section. The user will perceive it as the Passport's expiration date.