Merge lp://qastaging/~savoirfairelinux-openerp/openerp-icm/bug1160750 into lp://qastaging/~openerp-icm/openerp-icm/7.0
Proposed by
Sandy Carter (http://www.savoirfairelinux.com)
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 12 | ||||
| Proposed branch: | lp://qastaging/~savoirfairelinux-openerp/openerp-icm/bug1160750 | ||||
| Merge into: | lp://qastaging/~openerp-icm/openerp-icm/7.0 | ||||
| Diff against target: |
1633 lines (+504/-528) 12 files modified
sale_commission/__init__.py (+2/-3) sale_commission/__openerp__.py (+25/-27) sale_commission/invoice.py (+61/-56) sale_commission/partner.py (+7/-8) sale_commission/partner_agent.py (+43/-43) sale_commission/partner_view.xml (+1/-1) sale_commission/sale_agent.py (+30/-29) sale_commission/sale_order.py (+66/-64) sale_commission/settled.py (+235/-249) sale_commission/stock_picking.py (+23/-26) sale_commission/wizard/__init__.py (+1/-1) sale_commission/wizard/wizard_invoice.py (+10/-21) |
||||
| To merge this branch: | bzr merge lp://qastaging/~savoirfairelinux-openerp/openerp-icm/bug1160750 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maxime Chambreuil (http://www.savoirfairelinux.com) | test | Approve | |
| Jenkins Savoir-faire Linux (community) | test | Approve | |
| Guewen Baconnier @ Camptocamp | code review | Approve | |
|
Review via email:
|
|||
Description of the change
Revision of code including pep8, optimization of pools, some comment fixes.
It would be good to translate non-English state names, strings, function names, and, especially comments.
There still is some strange code that I was unable to revise due to lack of original intent.
Revision 14 assures that context is used as per Bug #1160750
Please do test, as there may be some bugs left or some regression.
To post a comment you must log in.
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Approve
(code review)
Revision history for this message
| Jenkins Savoir-faire Linux (jenkins-a) | # |
review:
Approve
(test)
Revision history for this message
| Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote | # |
review:
Approve
(test)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
As you said, there is still things to improve as untranslated stuffs. But this is already a good step forward. Thanks.
LGTM (not tested).