Partner and Contact Management

Merge lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp://qastaging/~partner-contact-core-editors/partner-contact-management/7.0

partner-contact-management-base_contact_add_modules
Merge into 7.0

Proposed by Sandy Carter (http://www.savoirfairelinux.com) on 2014-04-30

Status:	Needs review
Proposed branch:	lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules
Merge into:	lp://qastaging/~partner-contact-core-editors/partner-contact-management/7.0
Diff against target:	2416 lines (+2295/-0) 23 files modified base_contact_by_functions/__init__.py (+27/-0) base_contact_by_functions/__openerp__.py (+56/-0) base_contact_by_functions/functions.py (+41/-0) base_contact_by_functions/functions_view.xml (+38/-0) base_contact_by_functions/i18n/base_contact_by_functions.pot (+353/-0) base_contact_by_functions/i18n/fr.po (+353/-0) base_contact_by_functions/res_institutions.py (+49/-0) base_contact_by_functions/res_institutions_view.xml (+55/-0) base_contact_by_functions/res_partner.py (+102/-0) base_contact_by_functions/res_partner_view.xml (+526/-0) base_contact_by_functions/security/ir.model.access.csv (+5/-0) base_contact_by_functions/tests/__init__.py (+31/-0) base_contact_by_functions/tests/test_functions.py (+98/-0) base_contact_by_functions/tests/test_institutions.py (+99/-0) base_contact_by_functions/tests/test_partner_category.py (+105/-0) base_contact_by_functions_partner_firstname/__init__.py (+25/-0) base_contact_by_functions_partner_firstname/__openerp__.py (+53/-0) base_contact_by_functions_partner_firstname/i18n/base_contact_by_functions_partner_firstname.pot (+27/-0) base_contact_by_functions_partner_firstname/i18n/fr.po (+27/-0) base_contact_by_functions_partner_firstname/res_partner.py (+76/-0) base_contact_by_functions_partner_firstname/res_partner_view.xml (+71/-0) base_contact_by_functions_partner_firstname/tests/__init__.py (+27/-0) base_contact_by_functions_partner_firstname/tests/test_partner.py (+51/-0)
To merge this branch:	bzr merge lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Lorenzo Battistini (community)		Needs Resubmitting on 2014-07-23
Stefan Rijnhart (Opener)	2014-04-30	Needs Information on 2014-07-17
Sandy Carter (http://www.savoirfairelinux.com)		Abstain on 2014-04-30
Review via email: mp+217775@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-01-30.

Description of the change

- [ADD] added base_contact_by_functions module: It allow to manage contacts by function"
- [ADD] Added base_contact_by_functions_partner_firstname module: It allows to add firstname before name.Name is considered like the lastname and we have firstname and lastname on partner view and contact view."
The base_contact_by_functions_partner_firstname module depends on partner_firstname and base_contact_by_functions module.

Revision history for this message

Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) on 2014-03-21: Posted in a previous version of this proposal

review: Approve

Revision history for this message

Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) on 2014-04-30:

review: Abstain

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2014-07-17:

I have a hard time trying to find out what this module actually does. The manifest description is very terse. The name of the module reminds me of base_contact, which allowed multiple connections between the same person and a company. Is this module similar? The description should at least explain what 'institutions' are (a concept that this module introduces).

Terminology is off at times, it seems. l.130: 'acronym': is this abbreviation, or maybe stick to the standard 'code' field name and label?

Organism: I'm guessing you mean organization. But in any case, changing the 'company' terminology should be split off as a separate module.

The translations seem to contain obsolete terms, e.g. l.241 and other occurrences of 'passport'.

review: Needs Information

Revision history for this message

Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote on 2014-07-17:

This is for cases where one partner (Mike Fletcher President of Agrolait) can be part of another company (Mike Fletcher VP of AsusTEK) in a different function.

The module helps track these functions.

Revision history for this message

Lorenzo Battistini (elbati) wrote on 2014-07-23:

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

46. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-04-23

Fix KeyError which sometimes arises when installing modules.

Assert that contact_id exists in vals

45. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-03-12

Fix error when creating partner with contact info

44. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-03-03

adapt module for community firstname module

43. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-02-14

[IMP] is_company field is True by default and replace Organism by Parent Organism in form view

42. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-01-30

[ADD] added base_contact_by_functions_partner_firstname module: It allows to add firstname before name.Name is considered like the lastname and we have firstname and lastname on partner view and contact view.

41. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-01-30