Partner and Contact Management

Merge lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp://qastaging/~partner-contact-core-editors/partner-contact-management/7.0

  1. partner-contact-management-base_contact_add_partner_maiden_name
  2. Merge into 7.0
Status: Needs review
Proposed branch: lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
Merge into: lp://qastaging/~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 221 lines (+190/-0)
6 files modified
partner_maiden_name/__init__.py (+25/-0)
partner_maiden_name/__openerp__.py (+53/-0)
partner_maiden_name/i18n/fr.po (+32/-0)
partner_maiden_name/i18n/partner_maiden_name.pot (+32/-0)
partner_maiden_name/res_partner.py (+32/-0)
partner_maiden_name/res_partner_view.xml (+16/-0)
To merge this branch: bzr merge lp://qastaging/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
Reviewer Review Type Date Requested Status
Lorenzo Battistini (community) Needs Resubmitting
Sandy Carter (http://www.savoirfairelinux.com) Needs Fixing
Yannick Vaucher @ Camptocamp Needs Fixing
Partner and Contact Core Editors Pending
Review via email: mp+204023@code.qastaging.launchpad.net

Description of the change

-Add partner_maiden_name module: It allows to add the maiden name field to the partner.

To post a comment you must log in.
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Maybe rename the module and the field by "Previous name" or "birth name" as maiden name is

For now I won't approve it as there is a talk on firstname in community mailing list

review: Needs Information
Reply
Revision history for this message
El Hadji Dem (http://www.savoirfairelinux.com) (eh-dem) wrote :

Thanks for your comment. We decided to keep it.

There is a talk on firstname, I met some issues with this module and I decided to redefine the module.
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_firstname_lastname

Reply
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

Firstname has been implemented by lp:~acsone-openerp/partner-contact-management/7.0-partner-firstname

@Yannick, can you rexplain your objection, it seems to have been cut off: «as maiden name is» ...

review: Approve
Reply
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Sorry indeed something is missing

Thanks for the reminder

Correct me if I'm wrong but Maiden name is sexist and not accurate nor generic nowadays.

You should find enough altenatives with:
Maiden name -> birth name, surname at birth, original name, former name

review: Needs Fixing
Reply
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

@Yannick,
Thank you for pointing that out. Indeed, maiden name might be a charged, non-gender neutral name for the field and should be changed.

review: Needs Fixing
Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting
Reply

Unmerged revisions

33. By El Hadji Dem (http://www.savoirfairelinux.com)

[ADD] add partner_maiden_name module: It allows to add the maiden name field to the partner

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.