Merge lp://qastaging/~scopes-hackers/unity-lens-music/rb-scope into lp://qastaging/unity-lens-music

Proposed by David Callé
Status: Merged
Approved by: Michal Hruby
Approved revision: 102
Merged at revision: 73
Proposed branch: lp://qastaging/~scopes-hackers/unity-lens-music/rb-scope
Merge into: lp://qastaging/unity-lens-music
Diff against target: 813 lines (+663/-3)
11 files modified
configure.ac (+2/-1)
po/POTFILES.in (+2/-0)
po/POTFILES.skip (+2/-0)
src/Makefile.am (+3/-0)
src/banshee-scope.vala (+1/-0)
src/daemon.vala (+4/-0)
src/genre.vala (+18/-1)
src/rhythmbox-collection.vala (+489/-0)
src/rhythmbox-scope.vala (+116/-0)
src/simple-scope.vala (+19/-0)
src/track.vala (+7/-1)
To merge this branch: bzr merge lp://qastaging/~scopes-hackers/unity-lens-music/rb-scope
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Mikkel Kamstrup Erlandsen (community) Approve
Neil J. Patel (community) Approve
Review via email: mp+98294@code.qastaging.launchpad.net

Commit message

Implement a Rhythmbox scope.

Description of the change

Implement a Rhythmbox scope.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

There are still a couple of rough edges (better album handling, monitoring changes to the xml file), but I think it's good to go in for beta2.

review: Approve
Revision history for this message
Alex Launi (alexlauni) wrote :

This looks pretty ok, but there's a commented out FIXME where one would launch an album, so it appears that playing an album hasn't been implemented. Did I miss something?

Revision history for this message
Michal Hruby (mhr3) wrote :

> This looks pretty ok, but there's a commented out FIXME where one would launch
> an album, so it appears that playing an album hasn't been implemented. Did I
> miss something?

Currently albums aren't really handled - they behave same way like the song they are "extracted" from.

Revision history for this message
David Callé (davidc3) wrote :

For the record, Rhythmbox doesn't provide any way to launch albums.
One solution would be, on activation of an album result, to :

rhythmbox-client --play <track1 of album>
rhythmbox-client --enqueue <track2> <track3> <track4> ...

Or, to do what the python rbox scope does :

rhythmbox-client --play <track1 of album>
and "# pray for rhythmbox to be ordered by tracks"

Revision history for this message
Alex Launi (alexlauni) wrote :

the first solution is what's done in banshee, and what i would suggest doing.

Revision history for this message
Alex Launi (alexlauni) wrote :

well, not exactly what's done in banshee but that's what i would do

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I took the lens for a test spin but I am not getting any results from it. Looking at the code I think everything looks alright. I am not sure what gives (and I don't get any errors on stdout).

Nice to see that all the bells and whistles of Dee is being put to use! :-D

review: Needs Fixing
Revision history for this message
Michal Hruby (mhr3) wrote :

Mikkel, are you running fixed Dee (the non-C-locale issue)? If not run the lens with LC_ALL=C ./...

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Thanks Michal, that makes it work. I think that we can bump the build dep, now that Dee has been post-release-version-bumped.

Search works nicely, but it seems that the Genre filter doesn't work?

review: Needs Fixing
Revision history for this message
Neil J. Patel (njpatel) wrote :

Works well for me, genres included.

review: Approve
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Ok, on a clean jhbuild wiht everything up-to-date this is working fine. Running well here.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-music/10/console reported an error when processing this lp:~scopes-hackers/unity-lens-music/rb-scope branch.
Not merging it.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

New build-dep added.

Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-music/11/console reported an error when processing this lp:~scopes-hackers/unity-lens-music/rb-scope branch.
Not merging it.

102. By Michal Hruby

Update POTFILES

Revision history for this message
Michal Hruby (mhr3) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: