AppArmor

Merge lp://qastaging/~sdeziel/apparmor/user-mail into lp://qastaging/apparmor/2.12

user-mail
Merge into master

Proposed by Simon Déziel on 2016-04-14

Status:	Merged
Merged at revision:	3439
Proposed branch:	lp://qastaging/~sdeziel/apparmor/user-mail
Merge into:	lp://qastaging/apparmor/2.12
Diff against target:	12 lines (+1/-1) 1 file modified profiles/apparmor.d/abstractions/user-mail (+1/-1)
To merge this branch:	bzr merge lp://qastaging/~sdeziel/apparmor/user-mail
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Seth Arnold		2016-04-14	Approve on 2016-04-14
Review via email: mp+291934@code.qastaging.launchpad.net

Revision history for this message

Seth Arnold (seth-arnold) wrote on 2016-04-14:

Looks good to me, but tightening a rule in an abstraction feels like something that ought to be reviewed by several people..

THanks

Revision history for this message

Simon Déziel (sdeziel) wrote on 2016-04-14:

Since the rule matched only for files directly under /var/mail makes is a hint that it was always intended to cover users' mailboxes. But yeah, more reviewers would be welcome.

Revision history for this message

Christian Boltz (cboltz) wrote on 2016-04-14:

Looks good to me too - and I just checked that the files in /var/spool/mail/ are really owned by the respective user.

Seth, if you think two reviews are enough, please merge this ;-)

Revision history for this message

Seth Arnold (seth-arnold) wrote on 2016-04-14:

Thanks Christian, Simon!

Committed revision 3439.

review: Approve