Merge lp://qastaging/~seb128/ubuntu-system-settings/new-storage-ui into lp://qastaging/ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 60
Merged at revision: 61
Proposed branch: lp://qastaging/~seb128/ubuntu-system-settings/new-storage-ui
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 130 lines (+98/-1)
4 files modified
plugins/about/PageComponent.qml (+1/-0)
plugins/about/Storage.qml (+63/-0)
plugins/about/StorageBar.qml (+31/-0)
plugins/about/about.pro (+3/-1)
To merge this branch: bzr merge lp://qastaging/~seb128/ubuntu-system-settings/new-storage-ui
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+169869@code.qastaging.launchpad.net

Commit message

about: start work on the "storage" subpanel, that's a rough first version
of the UI that will need tweaking and improvement but at least that's a base
to build one

Description of the change

about: start work on the "storage" subpanel, that's a rough first version
of the UI that will need tweaking and improvement but at least that's a base
to build one

To post a comment you must log in.
58. By Sebastien Bacher

about: start work on the "storage" subpanel, that's a rough first version
of the UI that will need tweaking and improvement but at least that's a base
to build one

Revision history for this message
Sebastien Bacher (seb128) wrote :

sending again without stacking on another unmerged revision

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Use resolution independent sizes where possible. On the nexus 4 the value legend had alignment problems, but with tweaking the sizes in Storage.qml with resolution independent values, it looked great. Check out http://paste.ubuntu.com/5774962/

review: Needs Fixing
59. By Sebastien Bacher

use grid unit values, thanks Ken

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Ken, I pushed a new revision with your changes

60. By Sebastien Bacher

use slightly nicer colors

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches