webbrowser-app

Merge lp://qastaging/~seb128/webbrowser-app/clear-confirmation-tweaks into lp://qastaging/webbrowser-app

  1. clear-confirmation-tweaks
  2. Merge into trunk
Proposed by Sebastien Bacher
Status: Needs review
Proposed branch: lp://qastaging/~seb128/webbrowser-app/clear-confirmation-tweaks
Merge into: lp://qastaging/webbrowser-app
Diff against target: 35 lines (+9/-8)
1 file modified
src/app/webbrowser/SettingsPage.qml (+9/-8)
To merge this branch: bzr merge lp://qastaging/~seb128/webbrowser-app/clear-confirmation-tweaks
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
Review via email: mp+277884@code.qastaging.launchpad.net

Commit message

Consider the settings, "clear history/cache" actions as negative and
use a red button on the left for confirmation rather than a green on
the right.

Description of the change

Consider the settings, "clear history/cache" actions as negative and
use a red button on the left for confirmation rather than a green on
the right.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1278
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2480/
Executed test runs:
    ABORTED: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5245/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1234
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1234/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1234
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5265
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5265/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2480/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Olivier Tilloy (osomon) wrote :

The change makes sense and looks good to me. Will wait for confirmation from design before I top-approve though.

review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1278
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/2481/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5258
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-amd64-ci/1235
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1235
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-armhf-ci/1235/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-vivid-i386-ci/1235
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4173
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5278
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5278/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25266

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/2481/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

1278. By Sebastien Bacher

Consider the settings, "clear history/cache" actions as negative and
use a red button on the left for confirmation rather than a green on
the right.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: