whoopsie-preferences

Merge lp://qastaging/~seb128/whoopsie-preferences/touch-writable-image into lp://qastaging/whoopsie-preferences

  1. touch-writable-image
  2. Merge into trunk
Proposed by Sebastien Bacher
Status: Merged
Approved by: Iain Lane
Approved revision: 57
Merged at revision: 57
Proposed branch: lp://qastaging/~seb128/whoopsie-preferences/touch-writable-image
Merge into: lp://qastaging/whoopsie-preferences
Diff against target: 79 lines (+46/-2)
1 file modified
src/whoopsie-preferences.c (+46/-2)
To merge this branch: bzr merge lp://qastaging/~seb128/whoopsie-preferences/touch-writable-image
Reviewer Review Type Date Requested Status
Iain Lane (community) Approve
Review via email: mp+259531@code.qastaging.launchpad.net

Commit message

Hack to support system-image read-only /etc, and modify files in
/etc/writable/ instead (similar to what is used in systemd in Ubuntu)
(lp: #1437633)

Description of the change

Hack to support system-image read-only /etc, and modify files in
/etc/writable/ instead (similar to what is used in systemd in Ubuntu)
(lp: #1437633)

To post a comment you must log in.
lp://qastaging/~seb128/whoopsie-preferences/touch-writable-image updated
57. By Sebastien Bacher

Hack to support system-image read-only /etc, and modify files in
/etc/writable/ instead (similar to what is used in systemd in Ubuntu)
(lp: #1437633)

Revision history for this message
Iain Lane (laney) wrote :

I think this is fine. I was confused about why you use a static string for the return variable, but I suppose it's so you don't have to free it?

I have one small comment but I'll fix it when merging. Will test and upload.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks for the review

> I was confused about why you use a static string for the return variable, but I suppose it's so you don't have to free it?

right, that's what is done in the systemd patch and I though it was a good idea and that we could do the same here

Revision history for this message
Iain Lane (laney) wrote :

btw I had to add code to resolve the symlink to an absolute path (systemd has a helper to do this), because we create relative symlinks in livecd-rootfs but the code expects an absolute path

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches