Merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug569387 into lp://qastaging/percona-xtrabackup/2.1
Proposed by
Sergei Glushchenko
| Status: | Rejected |
|---|---|
| Rejected by: | Alexey Kopytov |
| Proposed branch: | lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug569387 |
| Merge into: | lp://qastaging/percona-xtrabackup/2.1 |
| Diff against target: |
1052 lines (+686/-143) 9 files modified
doc/source/innobackupex/partial_backups_innobackupex.rst (+1/-5) doc/source/xtrabackup_bin/partial_backups.rst (+6/-1) doc/source/xtrabackup_bin/xbk_option_reference.rst (+8/-0) innobackupex.pl (+8/-0) src/innodb_int.h (+2/-2) src/xtrabackup.cc (+338/-135) test/t/ib_databases.sh (+48/-0) test/t/ib_databases_file.sh (+57/-0) test/t/xb_databases_options.sh (+218/-0) |
| To merge this branch: | bzr merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.1-xb-bug569387 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexey Kopytov (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
To post a comment you must log in.
Unmerged revisions
- 757. By Sergei Glushchenko
-
Bug 569387: innobackupex ignores --databases without --stream
Changes:
- two options have been added for xtrabackup:
- "--databases" is a space separated list of entries
database_name[.table_ name]
- "--databases-file" is a name of file which contains entries
database_name[.table_ name] one entry per line
- check_if_table_matches_ filters has been modified to check whether
database is enabled first and then check the table
- databases and tables filters initialization has been refactored in
order to avoid code duplication
- innnobackupex's --databases option is mapped to one of these
options, depending on value.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looking at the diff, changes like these are too invasive for a CS release. Will review & merge only the 2.2 MP.