Merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1395143 into lp://qastaging/percona-xtrabackup/2.2
Proposed by
Sergei Glushchenko
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5056 |
Proposed branch: | lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1395143 |
Merge into: | lp://qastaging/percona-xtrabackup/2.2 |
Diff against target: |
185 lines (+45/-1) 5 files modified
storage/innobase/xtrabackup/src/compact.cc (+2/-0) storage/innobase/xtrabackup/src/ds_archive.c (+9/-0) storage/innobase/xtrabackup/src/ds_xbstream.c (+11/-0) storage/innobase/xtrabackup/src/xbcrypt_read.c (+2/-0) storage/innobase/xtrabackup/src/xtrabackup.cc (+21/-1) |
To merge this branch: | bzr merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1395143 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Sergei Glushchenko (community) | Needs Fixing | ||
Review via email:
|
Description of the change
Following leaks fixed:
- Memory allocated for pmap_cur in page_map_file_open was never
released.
- Memory allocated for ivbuffer in xb_crypt_read_open was never
released.
- Doublewrite buffer allocated in open_or_
not released after xtrabackup applied incremental deltas.
- dst_log_file was never released.
- fil_system was never released.
- Memory allocated in innodb_init_param was not allocated after
apply-log stage.
http://
To post a comment you must log in.
Sergei,
I wonder if we really need to set buf_dblwr to NULL after calling buf_dblwr_free() and fil_system to NULL after calling fil_close(). That seems to be redundant?