Percona XtraBackup moved to https://jira.percona.com/projects/PXB

Merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug569387 into lp://qastaging/percona-xtrabackup/2.2

  1. 2.2-xb-bug569387
  2. Merge into 2.2
Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 4995
Proposed branch: lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug569387
Merge into: lp://qastaging/percona-xtrabackup/2.2
Diff against target: 1051 lines (+674/-143)
9 files modified
storage/innobase/xtrabackup/doc/source/innobackupex/partial_backups_innobackupex.rst (+1/-5)
storage/innobase/xtrabackup/doc/source/xtrabackup_bin/partial_backups.rst (+6/-1)
storage/innobase/xtrabackup/doc/source/xtrabackup_bin/xbk_option_reference.rst (+8/-0)
storage/innobase/xtrabackup/innobackupex.pl (+8/-0)
storage/innobase/xtrabackup/src/xtrabackup.cc (+329/-135)
storage/innobase/xtrabackup/test/inc/common.sh (+2/-2)
storage/innobase/xtrabackup/test/t/ib_databases.sh (+46/-0)
storage/innobase/xtrabackup/test/t/ib_databases_file.sh (+56/-0)
storage/innobase/xtrabackup/test/t/xb_databases_options.sh (+218/-0)
To merge this branch: bzr merge lp://qastaging/~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug569387
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+231932@code.qastaging.launchpad.net

Description of the change

Manual merge from 2.1
http://jenkins.percona.com/job/percona-xtrabackup-2.2-param/181/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Needs Fixing
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

What will happened with inline comments after repush?

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Good question. Let's try and see? :)

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

They will be available: see for example https://code.launchpad.net/~hrvojem/percona-server/rn-5.1.73-14.2-5.1/+merge/228677, there is a "Show diff comments" link on the top right corner of the "Needs Fixing" box

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

http://jenkins.percona.com/view/PXB%202.2/job/percona-xtrabackup-2.2-param/182/
I updated the branch.
Changes are:
- xtrabackup_filter_entry_ -> xb_filter_entry_
- indentation fixes
- System character set is restricted to... comment removed
- Why not just "while (fgets(...))"? -- rewritten with while
- char* p = name_buf; is indeed redundant, removed
- Did you try replacing $@ with "$@" in innobackupex() and quoting the argument, i.e. "--databases='...'"? -- I didm't but I suspected it might work, done and it works
- Could just use die() here and other tests. -- done in 2 places
- xb_add_filter_entry_to_hash shortened to xb_add_filter

Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches