Ubuntu
qemu package

Merge ~sergiodj/ubuntu/+source/qemu:max-cpu-too-low-jammy into ubuntu/+source/qemu:ubuntu/jammy-devel

  1. Git
  2. lp:~sergiodj/ubuntu/+source/qemu
  3. max-cpu-too-low-jammy
  4. Merge into ubuntu/jammy-devel
Proposed by Sergio Durigan Junior
Status: Merged
Approved by: Andreas Hasenack
Approved revision: 1c1ca4abf019a0eacb242b3d79cf61861fcfedec
Merge reported by: Andreas Hasenack
Merged at revision: 1c1ca4abf019a0eacb242b3d79cf61861fcfedec
Proposed branch: ~sergiodj/ubuntu/+source/qemu:max-cpu-too-low-jammy
Merge into: ubuntu/+source/qemu:ubuntu/jammy-devel
Diff against target: 89 lines (+67/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/lp2012763-maxcpus-too-low.patch (+59/-0)
Reviewer Review Type Date Requested Status
Andreas Hasenack Approve
Bryce Harrington (community) Needs Information
Christian Ehrhardt  Pending
Canonical Server Reporter Pending
Review via email: mp+454078@code.qastaging.launchpad.net

Description of the change

This MP implements new Jammy machine options that can be used to launch VMs using more than 288 vCPUs.

It's a simple patch because everything else needed to launch and use such VMs is already part of QEMU and the Linux kernel. There's an extensive discussion on bug #2012763 explaining all the investigation I did to confirm that.

PPA: https://launchpad.net/~sergiodj/+archive/ubuntu/qemu-bug2012763/+packages

Because QEMU always keeps retroactive definitions of machine types for previous Ubuntu releases, this patch will need to be "forwardported" to Mantic and Noble. Fortunately, no new machine types will be needed for Noble because its QEMU already supports launching VMS with more than 288 vCPUs out of the box. Mantic will need a new machine type, however.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Guessing this is still WIP due to the description? Perhaps Status should set to the same for now?

One question is the changelog says this is for amd64, but the patch applies to qemu/hw/i386? Is that a mistake or intentional? May be something to mention in the dep3 text for the header when you get to that.

review: Needs Information
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Tuesday, November 28 2023, Bryce Harrington wrote:

> Guessing this is still WIP due to the description? Perhaps Status should set to the same for now?

Thanks, Bryce. Yeah, this is still WIP because the proposed change
apparently fails to address the bug. I haven't had the time to get back
to it yet.

> One question is the changelog says this is for amd64, but the patch applies to qemu/hw/i386? Is that a mistake or intentional? May be something to mention in the dep3 text for the header when you get to that.

qemu/hw/i386 is where x86 code is located; there's no
qemu/hw/{amd64,x86_64}. This is for historical reasons, I believe.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

This is ready to be reviewed.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Grabbing this one.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, compared the changes to the ones from mantic and noble, and I see the machine types are correctly transported between ubuntu releases.

There is a follow-up discussion we will have on how lxd can incorporate these changes in its embedded build of qemu, but it doesn't block this update.

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Thursday, March 21 2024, Andreas Hasenack wrote:

> Review: Approve
>
> +1, compared the changes to the ones from mantic and noble, and I see the machine types are correctly transported between ubuntu releases.
>
> There is a follow-up discussion we will have on how lxd can incorporate these changes in its embedded build of qemu, but it doesn't block this update.

Thanks. Uploaded:

$ dput qemu_6.2+dfsg-2ubuntu6.19_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/qemu/qemu_6.2+dfsg-2ubuntu6.19_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/qemu/qemu_6.2+dfsg-2ubuntu6.19.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading qemu_6.2+dfsg-2ubuntu6.19.dsc: done.
  Uploading qemu_6.2+dfsg-2ubuntu6.19.debian.tar.xz: done.
  Uploading qemu_6.2+dfsg-2ubuntu6.19_source.buildinfo: done.
  Uploading qemu_6.2+dfsg-2ubuntu6.19_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This is in jammy already, marking MP as merged.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches