poll-daemon

Merge lp://qastaging/~sergiusens/account-polld/notification_function into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

notification_function
Merge into trunk

Proposed by Sergio Schvezov on 2014-07-29

Status:	Merged
Approved by:	Roberto Alsina on 2014-07-29
Approved revision:	29
Merged at revision:	28
Proposed branch:	lp://qastaging/~sergiusens/account-polld/notification_function
Merge into:	lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Diff against target:	196 lines (+42/-83) 4 files modified plugins/facebook/facebook.go (+3/-12) plugins/gmail/gmail.go (+3/-15) plugins/plugins.go (+22/-0) plugins/twitter/twitter.go (+14/-56)
To merge this branch:	bzr merge lp://qastaging/~sergiusens/account-polld/notification_function
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2014-07-29
Roberto Alsina (community)			Approve on 2014-07-29
James Henstridge		2014-07-29	Pending
Review via email: mp+228657@code.qastaging.launchpad.net

Commit message

Notification function with common parameters

Description of the change

Just to remove duplication and make sure we use the default parameters

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-29:

PASSED: Continuous integration, rev:28
http://jenkins.qa.ubuntu.com/job/account-polld-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/26
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/26/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/26

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/26/rebuild

review: Approve (continuous-integration)

Revision history for this message

Roberto Alsina (ralsina) wrote on 2014-07-29:

Maybe you should also add a default tag in the notification, since that would allow for easier persistent notification management using the new API?

review: Needs Information

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-07-29:

> Maybe you should also add a default tag in the notification, since that would
> allow for easier persistent notification management using the new API?

A tag? What new thing is this? :-)

Revision history for this message

Roberto Alsina (ralsina) wrote on 2014-07-29:

Ha! Tags are new in 0.50 push-client, see
https://code.launchpad.net/~ralsina/ubuntu-push/remember-the-docs/+merge/228569
line 206 and later.

On Tue, Jul 29, 2014 at 11:06 AM, Sergio Schvezov <
<email address hidden>> wrote:

> > Maybe you should also add a default tag in the notification, since that
> would
> > allow for easier persistent notification management using the new API?
>
> A tag? What new thing is this? :-)
> --
>
> https://code.launchpad.net/~sergiusens/account-polld/notification_function/+merge/228657
> You are reviewing the proposed merge of
> lp:~sergiusens/account-polld/notification_function into lp:account-polld.
>