poll-daemon

Merge lp://qastaging/~sergiusens/account-polld/notifications into lp://qastaging/~phablet-team/account-polld/trunk

notifications
Merge into trunk

Proposed by Sergio Schvezov on 2014-07-16

Status:	Merged
Merged at revision:	9
Proposed branch:	lp://qastaging/~sergiusens/account-polld/notifications
Merge into:	lp://qastaging/~phablet-team/account-polld/trunk
Diff against target:	291 lines (+134/-34) 5 files modified cmd/account-polld/account_manager.go (+1/-1) cmd/account-polld/main.go (+49/-6) plugins/facebook/facebook.go (+9/-7) plugins/gmail/plugin.go (+13/-3) plugins/plugins.go (+62/-17)
To merge this branch:	bzr merge lp://qastaging/~sergiusens/account-polld/notifications
Related bugs:	Link a bug report
Related blueprints:	account-polld push and account notification (Undefined)

Reviewer	Date Requested	Status
James Henstridge	2014-07-16	Approve on 2014-07-17
Manuel de la Peña	2014-07-17	Pending
Review via email: mp+227099@code.qastaging.launchpad.net

Description of the change

Updating notifications using the API defined in http://ralsina.me/stories/push-docs.html

This includes being able to actually Push a message if the plugin responds to a poll (I've stubbed it in the gmail one).

Revision history for this message

James Henstridge (jamesh) wrote on 2014-07-17:

Looks good. Although I wonder why it needs to use the weird object path: if we were running confined, we wouldn't necessarily have access to each backend's path?

review: Approve

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-07-17:

On jueves 17 de julio de 2014 08h'11:51 ART, James Henstridge wrote:
> Review: Approve
>
> Looks good. Although I wonder why it needs to use the weird
> object path: if we were running confined, we wouldn't
> necessarily have access to each backend's path?

I don't like it either; I've brought it up and in any case the postal
service could do the traslation internally.

lp://qastaging/~sergiusens/account-polld/notifications updated on 2014-07-17