Merge lp://qastaging/~sergiusens/account-polld/qtcontact into lp://qastaging/~ubuntu-push-hackers/account-polld/trunk

Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 39
Merged at revision: 69
Proposed branch: lp://qastaging/~sergiusens/account-polld/qtcontact
Merge into: lp://qastaging/~ubuntu-push-hackers/account-polld/trunk
Prerequisite: lp://qastaging/~sergiusens/account-polld/to_poll_or_not_to_poll
Diff against target: 470 lines (+345/-11)
10 files modified
accounts/accounts.go (+0/-10)
cmd/account-polld/main.go (+10/-0)
cmd/qtcontact-test/main.go (+37/-0)
debian/control (+3/-0)
plugins/gmail/gmail.go (+5/-1)
qtcontact/contacts.go (+68/-0)
qtcontact/qtcontacts.cpp (+69/-0)
qtcontact/qtcontacts.h (+32/-0)
qtcontact/qtcontacts.hpp (+33/-0)
qtcontact/qtcontacts.moc (+88/-0)
To merge this branch: bzr merge lp://qastaging/~sergiusens/account-polld/qtcontact
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Roberto Alsina Pending
Review via email: mp+232097@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-07-30.

Commit message

Adding gmail avatar's through QtContacts

Description of the change

This seems to work standalone but falls short when integrated; I am thinking it's a Qt versus glib mainloop problem here.

I haven't done this in callback mode yet; not sure if it's worth it; please advice.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Roberto Alsina (ralsina) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Manuel de la Peña (mandel) : Posted in a previous version of this proposal
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches