poll-daemon

Merge lp://qastaging/~sergiusens/account-polld/reset_poll into lp://qastaging/~phablet-team/account-polld/trunk

  1. reset_poll
  2. Merge into trunk
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 26
Merged at revision: 25
Proposed branch: lp://qastaging/~sergiusens/account-polld/reset_poll
Merge into: lp://qastaging/~phablet-team/account-polld/trunk
Prerequisite: lp://qastaging/~sergiusens/account-polld/twitter_avatar
Diff against target: 17 lines (+4/-2)
1 file modified
cmd/account-polld/account_manager.go (+4/-2)
To merge this branch: bzr merge lp://qastaging/~sergiusens/account-polld/reset_poll
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
PS Jenkins bot continuous-integration Approve
Roberto Alsina Pending
Review via email: mp+228428@code.qastaging.launchpad.net

Commit message

Reset poll on success even when no new notifications come in.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:26
http://jenkins.qa.ubuntu.com/job/account-polld-ci/24/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-armhf-ci/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-polld-utopic-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-polld-ci/24/rebuild

review: Approve (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

I understand the existing behaviour is a bit suspect, but don't we also want to back off a bit when there are no notifications for a while?

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On lunes 28 de julio de 2014 05h'20:43 ART, James Henstridge wrote:
> I understand the existing behaviour is a bit suspect, but don't
> we also want to back off a bit when there are no notifications
> for a while?

I thought so as well, but after continous use over the weekend it was sort
of annoying - I'm a dogfooder as well :)

Revision history for this message
Manuel de la Peña (mandel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches