nuntium

Merge lp://qastaging/~sergiusens/nuntium/select_that into lp://qastaging/nuntium

select_that
Merge into trunk

Proposed by Sergio Schvezov on 2014-09-29

Status:

Merged

Approved by:

Ricardo Salveti on 2014-10-01

Approved revision:

Merged at revision:

Proposed branch:

lp://qastaging/~sergiusens/nuntium/select_that

Merge into:

lp://qastaging/nuntium

Diff against target:

526 lines (+217/-46)

8 files modified

mediator.go (+10/-2)
ofono/context_test.go (+12/-19)
ofono/modem.go (+7/-7)
storage/context.go (+113/-0)
telepathy/const.go (+10/-9)
telepathy/manager.go (+2/-2)
telepathy/message.go (+2/-2)
telepathy/service.go (+61/-5)

To merge this branch:

bzr merge lp://qastaging/~sergiusens/nuntium/select_that

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ricardo Salveti (community)			Approve on 2014-10-01
PS Jenkins bot	continuous-integration		Approve on 2014-10-01
Antti Kaijanmäki (community)		2014-09-29	Approve on 2014-09-30
Review via email: mp+236427@code.qastaging.launchpad.net

Commit message

Allow context selection over the org.ofono.mms.Service interface

Description of the change

More details here http://people.canonical.com/~sergiusens/mms/context_select/README.md

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-29:

FAILED: Continuous integration, rev:76
http://jenkins.qa.ubuntu.com/job/nuntium-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-amd64-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/11/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-i386-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nuntium-ci/11/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~sergiusens/nuntium/select_that updated on 2014-09-29

77. By Sergio Schvezov on 2014-09-29: Adding log on what is being tried for activation

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-29:

FAILED: Continuous integration, rev:77
http://jenkins.qa.ubuntu.com/job/nuntium-ci/12/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-amd64-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-i386-ci/12/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nuntium-ci/12/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Antti Kaijanmäki (kaijanmaki) wrote on 2014-09-30:

My go-fu is bad, but I don't see the service notifying when the PreferredContext property changes.

It's also problematic that the property sometimes is available and sometimes it's not. I can work around this in the bindings, but I need two things:

1) instead of adding/removing the property, have a "not set" value (empty string would do just fine) and have the interface report PropertyChanged signal each time the property is modified
2) or add a straight signal PreferredContextChangede when you add or remove the property.

Current implementation makes it really difficult (or almost impossible) to write bindings on Qt.

review: Needs Fixing

lp://qastaging/~sergiusens/nuntium/select_that updated on 2014-09-30

78. By Sergio Schvezov on 2014-09-30: Minor cleanup, always refreshed from stored context state

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-30:

FAILED: Continuous integration, rev:78
http://jenkins.qa.ubuntu.com/job/nuntium-ci/13/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-amd64-ci/13/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/13/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-i386-ci/13/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nuntium-ci/13/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~sergiusens/nuntium/select_that updated on 2014-09-30

79. By Sergio Schvezov on 2014-09-30: Emitting properties changed for preferred context and always having the property set

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-30:

PASSED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/nuntium-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-amd64-ci/14
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/14
        deb: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-armhf-ci/14/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nuntium-utopic-i386-ci/14

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/nuntium-ci/14/rebuild

review: Approve (continuous-integration)

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2014-09-30:

This now produces messages like

phablet@ubuntu-phablet:~$ dbus-monitor interface=org.ofono.mms.Service
signal sender=org.freedesktop.DBus -> dest=:1.192 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.192"
method call sender=:1.193 -> dest=org.ofono.mms serial=2 path=/org/ofono/mms/722341240403394; interface=org.ofono.mms.Service; member=SetProperty
   string "PreferredContext"
   variant object path "/c2"
signal sender=:1.190 -> dest=(null destination) serial=9 path=/org/ofono/mms/722341240403394; interface=org.ofono.mms.Service; member=PropertyChanged
   string "PreferredContext"
   variant object path "/c2