snap-confine

Merge lp://qastaging/~sergiusens/snap-confine/frameworkPathSupport into lp://qastaging/~snappy-dev/snap-confine/trunk

frameworkPathSupport
Merge into trunk

Proposed by Sergio Schvezov on 2015-05-26

Status:	Merged
Merged at revision:	65
Proposed branch:	lp://qastaging/~sergiusens/snap-confine/frameworkPathSupport
Merge into:	lp://qastaging/~snappy-dev/snap-confine/trunk
Diff against target:	74 lines (+15/-7) 2 files modified debian/changelog (+3/-0) src/main.c (+12/-7)
To merge this branch:	bzr merge lp://qastaging/~sergiusens/snap-confine/frameworkPathSupport
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Vogt (community)		2015-05-26	Approve on 2015-05-26
Review via email: mp+260189@code.qastaging.launchpad.net

Commit message

Allow executing from /frameworks

Revision history for this message

Michael Terry (mterry) on 2015-05-26:

Revision history for this message

Michael Vogt (mvo) wrote on 2015-05-26:

Looks good, thanks! Except for the issue that Mike already raised :) [approving assuming this gets fixed]

review: Approve

lp://qastaging/~sergiusens/snap-confine/frameworkPathSupport updated on 2015-05-26

66. By Sergio Schvezov on 2015-05-26: Updating messaging

Revision history for this message

Sergio Schvezov (sergiusens) wrote on 2015-05-26:

On Tue, May 26, 2015 at 05:57:31PM -0000, Michael Terry wrote:
>
>
> Diff comments:
> > + if (strstr(binary, apps_prefix) != binary &&
> > + strstr(binary, oem_prefix) != binary &&
> > + strstr(binary, frameworks_prefix) != binary)
> > die("binary must be inside /apps/%s/ or /oem/%s/", appname, appname);
>
> This message should be updated too.

Done