Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/1497108 into lp://qastaging/~snappy-dev/snapcraft/core

  1. 1497108
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 187
Merged at revision: 188
Proposed branch: lp://qastaging/~sergiusens/snapcraft/1497108
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 22 lines (+5/-7)
1 file modified
snapcraft/cmds.py (+5/-7)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/1497108
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+271855@code.qastaging.launchpad.net

Commit message

Use relative paths for image creation

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

I don't understand this, but it works, so +1.

Should this be a bug on udf? or is something that python's exec causes?

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On Mon, Sep 21, 2015 at 8:38 PM, Leo Arias <email address hidden> wrote:

> Review: Approve
>
> I don't understand this, but it works, so +1.
>
> Should this be a bug on udf? or is something that python's exec causes?
>

I am thinking kpartx fails on char [MAXLEN] or something like that. I
forgot to assign it earlier in the report

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches