Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/1500728 into lp://qastaging/~snappy-dev/snapcraft/core

  1. 1500728
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 214
Merged at revision: 213
Proposed branch: lp://qastaging/~sergiusens/snapcraft/1500728
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 74 lines (+18/-1)
3 files modified
integration-tests/data/simple-tar/snapcraft.yaml (+3/-0)
integration-tests/units/jobs.pxu (+3/-0)
snapcraft/sources.py (+12/-1)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/1500728
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Michael Vogt (community) Approve
Review via email: mp+272697@code.qastaging.launchpad.net

Commit message

Mask tar files so they are writable and set an extraction parameter to start with a clean build dir

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks great! One minor comment.

review: Approve
lp://qastaging/~sergiusens/snapcraft/1500728 updated
214. By Sergio Schvezov

Added a comment about masking

Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches