Merge lp://qastaging/~sergiusens/snapcraft/1500758 into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov
Status: Merged
Approved by: John Lenton
Approved revision: 216
Merged at revision: 215
Proposed branch: lp://qastaging/~sergiusens/snapcraft/1500758
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 95 lines (+69/-0)
5 files modified
integration-tests/data/simple-scons/SConstruct (+14/-0)
integration-tests/data/simple-scons/main.c (+5/-0)
integration-tests/data/simple-scons/snapcraft.yaml (+11/-0)
plugins/scons-project.yaml (+8/-0)
snapcraft/plugins/scons_project.py (+31/-0)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/1500758
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Daniel Holbach Pending
Review via email: mp+272728@code.qastaging.launchpad.net

Commit message

Adding a simple scons plugin

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

LGTM. Just one question.

Revision history for this message
Sergio Schvezov (sergiusens) :
Revision history for this message
John Lenton (chipaca) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches