Merge lp://qastaging/~sergiusens/snapcraft/1500902 into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Sergio Schvezov | ||||||||
| Approved revision: | 249 | ||||||||
| Merged at revision: | 236 | ||||||||
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/1500902 | ||||||||
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core | ||||||||
| Diff against target: |
1329 lines (+398/-381) 33 files modified
plugins/ant.yaml (+0/-13) plugins/autotools.yaml (+0/-12) plugins/cmake.yaml (+0/-12) plugins/copy.yaml (+0/-6) plugins/go.yaml (+0/-10) plugins/jdk.yaml (+0/-2) plugins/make.yaml (+0/-10) plugins/maven.yaml (+0/-13) plugins/python2.yaml (+0/-11) plugins/python3.yaml (+0/-11) plugins/readline.yaml (+0/-3) plugins/scons.yaml (+0/-9) plugins/tar-content.yaml (+0/-6) setup.py (+0/-2) snapcraft/__init__.py (+47/-7) snapcraft/cmds.py (+7/-8) snapcraft/plugin.py (+106/-110) snapcraft/plugins/ant.py (+15/-5) snapcraft/plugins/autotools.py (+21/-2) snapcraft/plugins/cmake.py (+21/-6) snapcraft/plugins/copy.py (+13/-0) snapcraft/plugins/go.py (+15/-0) snapcraft/plugins/jdk.py (+3/-3) snapcraft/plugins/make.py (+4/-0) snapcraft/plugins/maven.py (+9/-1) snapcraft/plugins/python2.py (+19/-12) snapcraft/plugins/python3.py (+19/-12) snapcraft/plugins/qml.py (+41/-35) snapcraft/plugins/scons.py (+19/-5) snapcraft/plugins/tar_content.py (+13/-0) snapcraft/tests/test_cmds.py (+3/-3) snapcraft/tests/test_plugin.py (+18/-29) snapcraft/yaml.py (+5/-23) |
||||||||
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/1500902 | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Approve | ||
| John Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Plugin yaml's are obsolete
To post a comment you must log in.
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | # |
Revision history for this message
| John Lenton (chipaca) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
A couple of style comments inline.
This change makes sense, because now we don't split the plugins into a python and a yaml file. But I think we need to spend some time cleaning and documenting the api of the parent base plugin. Clearly mark things that are internals, constants and things that are to be extended by children. And write nice sphinxed docs.