Merge lp://qastaging/~sergiusens/snapcraft/1501413 into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | John Lenton | ||||
| Approved revision: | 223 | ||||
| Merged at revision: | 223 | ||||
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/1501413 | ||||
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core | ||||
| Diff against target: |
118 lines (+20/-3) 9 files modified
integration-tests/data/assemble/snapcraft.yaml (+1/-0) integration-tests/data/build-tools/snapcraft.yaml (+1/-0) integration-tests/data/local-plugin/snapcraft.yaml (+1/-0) integration-tests/data/local-source/snapcraft.yaml (+1/-0) integration-tests/data/simple-cmake/snapcraft.yaml (+1/-0) integration-tests/data/simple-make-filesets/snapcraft.yaml (+1/-0) integration-tests/data/simple-make/snapcraft.yaml (+1/-0) snapcraft/cmds.py (+5/-0) snapcraft/yaml.py (+8/-3) |
||||
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/1501413 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergio Schvezov | Approve | ||
| John Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Do not infer a plugin from the part name
To post a comment you must log in.
Revision history for this message
| John Lenton (chipaca) wrote | # |
Revision history for this message
| John Lenton (chipaca) wrote | # |
Revision history for this message
| Sergio Schvezov (sergiusens) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM; a nit and a hint.