Merge lp://qastaging/~sergiusens/snapcraft/1506096 into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | Sergio Schvezov |
| Approved revision: | 238 |
| Merged at revision: | 239 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/1506096 |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
91 lines (+19/-12) 3 files modified
setup.py (+1/-6) snapcraft/sources.py (+14/-4) snapcraft/tests/test_sources.py (+4/-2) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/1506096 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Federico Gimenez (community) | Approve | ||
| John Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Run unit tests when building the deb and make a failing test work
Description of the change
The things you do for love^wtests.
It seems that when running inside a package build proxies are defaulted to. I also took the opportunity to get rid of using wget and just stick with requests.
Using requests does have the drawback of not being able to continue a download (in this implementation at least), but forcing pull again will do the right thing, so take it as you wish.
I will be working during 0.4 to get rid of all the return True/False they are driving me nuts!
To post a comment you must log in.
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | # |
Revision history for this message
| Federico Gimenez (fgimenez) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm!