Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/1506205 into lp://qastaging/~snappy-dev/snapcraft/core

  1. 1506205
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 240
Merged at revision: 241
Proposed branch: lp://qastaging/~sergiusens/snapcraft/1506205
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 303 lines (+144/-28)
6 files modified
integration-tests/data/wiki/snapcraft.yaml (+16/-0)
integration-tests/units/jobs.pxu (+7/-0)
snapcraft/tests/test_wiki.py (+33/-7)
snapcraft/tests/test_yaml.py (+52/-14)
snapcraft/wiki.py (+20/-0)
snapcraft/yaml.py (+16/-7)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/1506205
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Review via email: mp+274485@code.qastaging.launchpad.net

Commit message

Search the wiki if the plugin keyword is missing for a part. Tests related to wiki searches are improved

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

I couldn't be happier with this branch.

review: Approve
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~sergiusens/snapcraft/1506205 into lp:snapcraft failed. Below is the output from the failed tests.

snapcraft/wiki.py:54:80: E501 line too long (80 > 79 characters)

lp://qastaging/~sergiusens/snapcraft/1506205 updated
240. By Sergio Schvezov

Search the wiki if the plugin keyword is missing for a part

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches