Merge lp://qastaging/~sergiusens/snapcraft/clean into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | John Lenton |
| Approved revision: | 176 |
| Merged at revision: | 175 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/clean |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
242 lines (+158/-1) 7 files modified
integration-tests/units/jobs.pxu (+16/-0) snapcraft/__init__.py (+1/-0) snapcraft/cmds.py (+21/-0) snapcraft/common.py (+4/-0) snapcraft/main.py (+3/-0) snapcraft/plugin.py (+2/-1) snapcraft/tests/test_cmds.py (+111/-0) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/clean |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add a clean command
To post a comment you must log in.
Revision history for this message
| Leo Arias (elopio) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is good, and works.
From our discussion on IRC, I'd like to see one integration test calling clean. And delete the parts dir if all the parts were removed by clean.
<sergiusens> elopio, like for every test possible?
<elopio> sergiusens: no, just one execution of clean.
<sergiusens> elopio, as in, for every test run in there?
<sergiusens> elopio, ok, I don't mind that :-)
<elopio> sergiusens: the parts directory is not removed.
<elopio> is that on purpose?
<sergiusens> elopio, yes; inside parts you can also have local plugins
<sergiusens> elopio, it's sort of a safe haven for things
<elopio> sergiusens: what about removing it if it's empty?
<sergiusens> elopio, so instead of removing everything I thought it be safer this way
<sergiusens> elopio, yeah, that can be arranged
<elopio> just feels weird to leave behind only one empty dir.