Merge lp://qastaging/~sergiusens/snapcraft/help into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 267
Merged at revision: 254
Proposed branch: lp://qastaging/~sergiusens/snapcraft/help
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 583 lines (+376/-10)
14 files modified
snapcraft/__init__.py (+103/-9)
snapcraft/help.py (+73/-0)
snapcraft/main.py (+11/-0)
snapcraft/plugins/ant.py (+10/-0)
snapcraft/plugins/autotools.py (+20/-0)
snapcraft/plugins/catkin.py (+13/-0)
snapcraft/plugins/cmake.py (+16/-0)
snapcraft/plugins/go.py (+13/-0)
snapcraft/plugins/make.py (+10/-0)
snapcraft/plugins/maven.py (+16/-0)
snapcraft/plugins/python2.py (+20/-0)
snapcraft/plugins/python3.py (+20/-0)
snapcraft/plugins/scons.py (+15/-0)
snapcraft/sources.py (+36/-1)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/help
Reviewer Review Type Date Requested Status
John Lenton (community) Approve
Review via email: mp+275858@code.qastaging.launchpad.net

Commit message

Adding a help command to get snapcraft help from the cli.

To post a comment you must log in.
Revision history for this message
John Lenton (chipaca) wrote :

Nice work.

Loots of comments, below ... needsfixing just because they're so many.

review: Needs Fixing
Revision history for this message
John Lenton (chipaca) wrote :

Mucho bettero!
One that I didn't catch last time. But +1'ing it.

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) :
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

The attempt to merge lp:~sergiusens/snapcraft/help into lp:snapcraft failed. Below is the output from the failed tests.

snapcraft/help.py:19: 'sys' imported but unused

Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches