Merge lp://qastaging/~sergiusens/snapcraft/mapnames into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 185
Merged at revision: 185
Proposed branch: lp://qastaging/~sergiusens/snapcraft/mapnames
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 517 lines (+97/-142)
15 files modified
examples/downloader-with-wiki-parts/snapcraft.yaml (+2/-1)
examples/godd/snapcraft.yaml (+2/-1)
examples/gopaste/snapcraft.yaml (+1/-1)
examples/java-hello-world/snapcraft.yaml (+1/-1)
examples/libpipeline/snapcraft.yaml (+2/-1)
examples/py2-project/snapcraft.yaml (+2/-1)
examples/py3-project/snapcraft.yaml (+2/-1)
examples/qmldemo/snapcraft.yaml (+1/-1)
examples/tomcat-maven-webapp/snapcraft.yaml (+1/-1)
examples/webcam-webui/snapcraft.yaml (+1/-1)
integration-tests/data/assemble/snapcraft.yaml (+5/-5)
schema/snapcraft.yaml (+13/-16)
snapcraft/meta.py (+22/-16)
snapcraft/tests/test_meta.py (+24/-66)
snapcraft/tests/test_yaml.py (+18/-29)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/mapnames
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Daniel Holbach Pending
Michael Vogt Pending
Review via email: mp+271799@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-09-21.

Commit message

Using a map instead of list for binaries and services as defined by the spec

To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote : Posted in a previous version of this proposal

Looks good.

review: Approve
Revision history for this message
Michael Vogt (mvo) wrote : Posted in a previous version of this proposal

Looks good.

review: Approve
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote : Posted in a previous version of this proposal

More than one proposal found for merge of https://code.launchpad.net/~sergiusens/snapcraft/config into https://code.launchpad.net/~snappy-dev/snapcraft/core, which is not Superseded.

Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote : Posted in a previous version of this proposal

More than one proposal found for merge of https://code.launchpad.net/~sergiusens/snapcraft/config into https://code.launchpad.net/~snappy-dev/snapcraft/core, which is not Superseded.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

I resubmitted to get rid of the tarmac issue

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches