Merge lp://qastaging/~sergiusens/snapcraft/module_name into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | Leo Arias |
| Approved revision: | 191 |
| Merged at revision: | 191 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/module_name |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
130 lines (+6/-16) 12 files modified
integration-tests/data/local-plugin/parts/plugins/x-local-plugin.yaml (+0/-1) plugins/ant-project.yaml (+0/-1) plugins/autotools-project.yaml (+0/-1) plugins/cmake-project.yaml (+0/-1) plugins/go-project.yaml (+0/-1) plugins/make-project.yaml (+0/-1) plugins/maven-project.yaml (+0/-1) plugins/python2-project.yaml (+0/-1) plugins/python3-project.yaml (+0/-1) plugins/tar-content.yaml (+0/-1) snapcraft/plugin.py (+5/-5) snapcraft/tests/test_plugin.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/module_name |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Remove modules from plugins and infer it from the file name to follow the spec
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm, all tests pass.