Merge lp://qastaging/~sergiusens/snapcraft/pull-python-projects into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | John Lenton |
| Approved revision: | 204 |
| Merged at revision: | 202 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/pull-python-projects |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
407 lines (+133/-152) 11 files modified
integration-tests/data/pip-requirements/snapcraft.yaml (+2/-2) plugins/python2-project.yaml (+3/-3) plugins/python2.yaml (+0/-3) plugins/python3-project.yaml (+3/-3) plugins/python3.yaml (+0/-3) runtests.sh (+1/-1) snapcraft/cmds.py (+2/-0) snapcraft/plugins/python2.py (+0/-63) snapcraft/plugins/python2_project.py (+60/-4) snapcraft/plugins/python3.py (+0/-65) snapcraft/plugins/python3_project.py (+62/-5) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/pull-python-projects |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| John Lenton (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make the py 2 and 3 projects smarter and have dependencies pulled during the pull phase
Description of the change
This is a side effect of needing internet access only done during the pull phases of the lifecycle to comply with launchpad.
It would be possible if the python2 or python3 plugins could be staged before running the pull cycle for the corresponding -project ones. Since this is not a viable alternative, moving everything to the py projects is what was done.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm.