Merge lp://qastaging/~sergiusens/snapcraft/pypy-config-test into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | Leo Arias |
| Approved revision: | 177 |
| Merged at revision: | 176 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/pypy-config-test |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
131 lines (+103/-0) 4 files modified
integration-tests/data/pypi-config/config.py (+57/-0) integration-tests/data/pypi-config/setup.py (+16/-0) integration-tests/data/pypi-config/snapcraft.yaml (+16/-0) integration-tests/units/jobs.pxu (+14/-0) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/pypy-config-test |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-09-17.
Commit message
setup.py using pypy to setup a config integration test
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I find it a little confusing that the part is also called config. Not sure what to do about it. That's not required, right? You could define any name for the part?
The test passes and excercises the code, that's good.
+ test -f ./snap/
IMO, this check is not enough. The best test would be to try to configure the installed snap, but as we still have some things to figure out for that, it would be good to check that the config file contains the same line that was defined on the yaml.
Needs fixing to add a check for the content of snap/meta/