Merge lp://qastaging/~sergiusens/snapcraft/scons_options into lp://qastaging/~snappy-dev/snapcraft/core
Proposed by
Sergio Schvezov
| Status: | Merged |
|---|---|
| Approved by: | Leo Arias |
| Approved revision: | 219 |
| Merged at revision: | 219 |
| Proposed branch: | lp://qastaging/~sergiusens/snapcraft/scons_options |
| Merge into: | lp://qastaging/~snappy-dev/snapcraft/core |
| Diff against target: |
97 lines (+31/-6) 5 files modified
integration-tests/data/simple-scons/SConstruct (+12/-4) integration-tests/data/simple-scons/snapcraft.yaml (+2/-0) integration-tests/units/jobs.pxu (+8/-0) plugins/scons-project.yaml (+1/-0) snapcraft/plugins/scons_project.py (+8/-2) |
| To merge this branch: | bzr merge lp://qastaging/~sergiusens/snapcraft/scons_options |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leo Arias (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Allow parameters/options for scons
To post a comment you must log in.
Revision history for this message
| Leo Arias (elopio) wrote | # |
Revision history for this message
| Leo Arias (elopio) | # |
review:
Needs Fixing
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Could you add options to the scons project in the integration suite, so this is tested?