Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/setuptools into lp://qastaging/~snappy-dev/snapcraft/core

  1. setuptools
  2. Merge into core
Proposed by Sergio Schvezov
Status: Rejected
Rejected by: Sergio Schvezov
Proposed branch: lp://qastaging/~sergiusens/snapcraft/setuptools
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 38 lines (+9/-2)
2 files modified
snapcraft/plugins/python2.py (+1/-1)
snapcraft/plugins/python2_project.py (+8/-1)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/setuptools
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Leo Arias (community) Needs Information
Review via email: mp+267121@code.qastaging.launchpad.net

Commit message

setuptools for python 2 projects

Description of the change

Something like this MP is needed for this to work:
https://github.com/sergiusens/galileo

I don't think this is the final solution, but I am not sure how to proceed either.

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

<elopio> sergiusens: can't you specify the python-setuptools dependency in the yaml of your package?
<elopio> there are other setup packages, so not all will require setuptools.

review: Needs Information
Revision history for this message
Michael Vogt (mvo) wrote :

I think we should merge the python2_project changes if that unblocks you. The python-setuptools could come via the snapcraft.yaml as well.

review: Approve
Revision history for this message
Zygmunt Krynicki (zyga) :
Revision history for this message
Björn Tillenius (bjornt) wrote :

> <elopio> sergiusens: can't you specify the python-setuptools dependency in the
> yaml of your package?
> <elopio> there are other setup packages, so not all will require setuptools.

How would you specify python-setuptools in the yaml?

Anyway, I think setuptools is so widespread, that it makes sense to support it by
default. It will lower the entry bar a lot.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches