Snapcraft

Merge lp://qastaging/~sergiusens/snapcraft/source-tests into lp://qastaging/~snappy-dev/snapcraft/core

  1. source-tests
  2. Merge into core
Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 151
Merged at revision: 147
Proposed branch: lp://qastaging/~sergiusens/snapcraft/source-tests
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Prerequisite: lp://qastaging/~sergiusens/snapcraft/less-source
Diff against target: 253 lines (+239/-0)
1 file modified
snapcraft/tests/test_sources.py (+239/-0)
To merge this branch: bzr merge lp://qastaging/~sergiusens/snapcraft/source-tests
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Michael Vogt (community) Approve
Review via email: mp+269649@code.qastaging.launchpad.net

Commit message

Unit tests for sources

Description of the change

For all but Tar.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

This looks great, one whitespace remark because I wanted to comment on at least one line :) But seriously, good stuff and fine to merge.

review: Approve
Revision history for this message
Snappy Tarmac (snappydevtarmac) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

bzr pump from previous review and white space fix from review

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches